Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: InlineSelect ability #5963

Merged
merged 11 commits into from
Oct 6, 2023
Merged

feat: InlineSelect ability #5963

merged 11 commits into from
Oct 6, 2023

Conversation

canerakdas
Copy link
Member

Description

The InlineSelect ability added to the Select component

Validation

image image image

Related Issues

fixes #5913

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner October 4, 2023 09:15
@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 3:15pm

ovflowd
ovflowd requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the figmas the icons should be bigger (https://www.figma.com/file/pu1vZPqNIM7BePd6W8APA5/Node.js?node-id=497%3A9542&mode=dev)

@ovflowd ovflowd added the hacktoberfest This Issue is meant for Hacktoberfest 2023 label Oct 4, 2023
@canerakdas canerakdas marked this pull request as draft October 4, 2023 16:02
ovflowd
ovflowd approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) :shipit:

@ovflowd
Copy link
Member

ovflowd commented Oct 5, 2023

@canerakdas the PR is still marked as draft, is there anything you want to change?

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 5, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.95% (201/221) 72% (36/50) 87.75% (43/49)

Unit Test Report

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 4.821s ⏱️

@canerakdas
Copy link
Member Author

@canerakdas the PR is still marked as draft, is there anything you want to change?

@ovflowd We use many styles in common with the Select component here, I want to double-check and make sure there is no styling I missed.

@canerakdas canerakdas marked this pull request as ready for review October 5, 2023 07:51
@canerakdas
Copy link
Member Author

canerakdas commented Oct 5, 2023 •
edited
Loading

I found a difference in the dropdown's border-radius sizes.

Thanks for the reviews and your patience! @ovflowd @aymen94

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 5, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 5, 2023
@ovflowd ovflowd added this pull request to the merge queue Oct 5, 2023
Merged via the queue into nodejs:main with commit 6109d75 Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
hacktoberfest This Issue is meant for Hacktoberfest 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create InlineSelect variant of the Select component
3 participants
@canerakdas @ovflowd @aymen94